Professional software engineer, musician, gamer, stoic, democratic socialist

  • 0 Posts
  • 11 Comments
Joined 3 years ago
cake
Cake day: July 2nd, 2023

help-circle




  • the code you have to review hasn’t been thought about

    Isn’t that just admitting that the author of the PR has not read the code they’re submitting? If I caught wind of that I would reject the PR on principle without even reading all of it.

    If you are competent and using an LLM to generate code you’ll put your name to, that mean reviewing a lot of code that isn’t up to your usual quality, rather than just writing it yourself, which is frankly extreme tedious, demoralising, and mentally exhausting

    That’s not been my experience. While there are often multiple iterations of feedback I go through with an LLM before I consider a PR ready, it’s rarely a significant deviation from what I already planned out. Most often it’s just basic code organization that I forgot to specify (especially if the area of code it’s working on was already poorly organized), or tradeoffs I wasn’t even aware of until the code was written. The amount of effort per cycle is usually very small, and I’m able to work on other things in between (like reviewing other peoples’ code).

    If you’re not competent, you wont catch any of that, and it’ll either just go to production, or it’ll fall to someone else to review it.

    This sounds mostly like a workplace culture problem. It’s always been important to have a high bar on code review to catch poor quality. Not to catch bugs per se, but to catch code that isn’t properly tested.

    you’re going to end up flooded with low quality commits from coworkers who’ve either given up or weren’t competent in the first place

    Again, that’s a workplace culture problem. You need to either stick to your principles and try to enact change, quit, or go along to get along. I’m sorry if the last option is where you’re at and that does suck.

    it’s much harder to train people to good practice when they’re abdicating the thinking to a machine

    I totally agree. That’s something each engineering org needs to reckon with, lest they burn out the devs who care about code quality.



  • I think you’re thinking about this in a very negative way when you also have the option to see it as an opportunity. You said yourself that now you’re focused more on design and architecture, and most of your time is spent reviewing code. That sounds like a relatively good place to be, assuming you’re happy with the quality of the code. Now you can spend more time solving new, harder problems that you couldn’t before.